mihaibudiu commented on code in PR #4495:
URL: https://github.com/apache/calcite/pull/4495#discussion_r2261610945
##########
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##########
@@ -227,7 +227,8 @@ public static SqlCall stripSeparator(SqlCall call) {
@Override public RelDataType
inferReturnType(SqlOperatorBinding opBinding) {
final RelDataType type = super.inferReturnType(opBinding);
- if (opBinding.getGroupCount() == 0 || opBinding.hasFilter()) {
+ if (opBinding.allowChangeNullable()
Review Comment:
Maybe the parameter should be called "aggregateResultIsNullable"?
There is nothing to infer - you already know it.
You are changing a bunch of public methods, not sure about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
