xiedeyantu commented on code in PR #4495:
URL: https://github.com/apache/calcite/pull/4495#discussion_r2268393356
##########
core/src/main/java/org/apache/calcite/rel/core/Aggregate.java:
##########
@@ -612,7 +616,20 @@ public AggCallBinding(RelDataTypeFactory typeFactory,
SqlAggFunction aggFunction, List<RelDataType> operands, int groupCount,
boolean filter) {
this(typeFactory, aggFunction, ImmutableList.of(), operands, groupCount,
- filter);
+ filter, true);
+ }
+
+ @Deprecated
+ // This constructor will be replaced by the constructor with
allowChangeNullable.
Review Comment:
Can I change it to this? @julianhyde
```
@Deprecated // to be removed before 2.0
public AggCallBinding(RelDataTypeFactory typeFactory,
SqlAggFunction aggFunction, List<RelDataType> preOperands,
List<RelDataType> operands, int groupCount,
boolean filter) {
this(typeFactory, aggFunction, preOperands, operands, groupCount,
filter, true);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
