ajegou commented on PR #4503: URL: https://github.com/apache/calcite/pull/4503#issuecomment-3211130795
> I took a quick look at the code and I suggest that this kind of optimization is best done in the rules, and RelBuilder is best not to do too much optimization. As Mihai said, you can raise a JIRA ticket first, so that other people will give you more suggestions. Yes, I totally agree that this (pushing down limits) should be in the rules. But to clarify, what this does is to limit the scope of this optimization so we do not do it for window functions, as it's incorrect in that case. But removing that limit pushdown logic entirely from the RelBuilder would also work I just filed the ticket for this, it should be clearer there: https://issues.apache.org/jira/browse/CALCITE-7144 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
