xiedeyantu commented on code in PR #4495: URL: https://github.com/apache/calcite/pull/4495#discussion_r2295005148
########## core/src/test/resources/sql/agg.iq: ########## @@ -776,14 +776,14 @@ group by rollup(deptno, gender); | 1 | 0 | 0 | 0 | 0 | 0 | 0 | | 1 | 0 | 0 | 0 | 0 | 0 | 0 | | 1 | 0 | 0 | 0 | 0 | 0 | 0 | -| 2 | 0 | 0 | 0 | 0 | 0 | 0 | -| 9 | 1 | 0 | 1 | 1 | 3 | 3 | | 1 | 0 | 0 | 0 | 1 | 2 | 1 | | 1 | 0 | 0 | 0 | 1 | 2 | 1 | | 1 | 0 | 0 | 0 | 1 | 2 | 1 | +| 2 | 0 | 0 | 0 | 0 | 0 | 0 | Review Comment: If you all think adding an ORDER BY would be better, then I'll add one, because I think adding an ORDER BY would increase the number of modified rows, making it harder to observe, and generally, the smallest changes are best. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
