strongduanmu commented on code in PR #275:
URL: https://github.com/apache/calcite-avatica/pull/275#discussion_r2296091512
##########
core/src/test/java/org/apache/calcite/avatica/CursorFactoryDeduceTest.java:
##########
@@ -244,6 +260,88 @@ protected static class SimplePOJO {
assertFalse(cursor.next());
}
}
+
+ @Test public void deduceRecordCursorFactoryProjectedSignedField() throws
Exception {
+ List<ColumnMetaData> columnsMetaDataList = Arrays.asList(
+ MetaImpl.columnMetaData("byteField", 1, ColumnMetaData.scalar(
+ Types.TINYINT, "TINYINT", ColumnMetaData.Rep.BYTE), true, true),
+ MetaImpl.columnMetaData("shortField", 2, ColumnMetaData.scalar(
+ Types.SMALLINT, "SMALLINT", ColumnMetaData.Rep.SHORT), true, true),
+ MetaImpl.columnMetaData("intField", 3, ColumnMetaData.scalar(
Review Comment:
Yes, while I was adding tests for unsigned types, I noticed that signed
types were also lacking tests, so I added those tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
