mihaibudiu commented on code in PR #4505:
URL: https://github.com/apache/calcite/pull/4505#discussion_r2298622932


##########
core/src/main/java/org/apache/calcite/plan/Strong.java:
##########
@@ -265,6 +266,22 @@ public boolean isNull(RexNode node) {
         return anyNull(rexCall.getOperands());
       }
       return false;
+    case DIVIDE: {

Review Comment:
   Julian left some comments in the JIRA about this choice.
   But the fact that the literal is zero is irrelevant; the result is the same 
for all non-null literals.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to