michalstutzmann commented on code in PR #4501:
URL: https://github.com/apache/calcite/pull/4501#discussion_r2324219494
##########
core/src/main/java/org/apache/calcite/sql/type/FunctionSqlType.java:
##########
@@ -58,6 +68,20 @@ public FunctionSqlType(
return this;
}
+ /**
+ * Returns the parameter type of the function.
+ *
+ * @return a struct wrapping function's parameter types.
+ */
+ public RelDataType getParameterType() {
Review Comment:
I'd suggest to leave this method name (getter) intact as it follows the
established convention for getters (and is in line with constructor parameter
names and the other getter `getReturnType`).
We could add another method with the proposed name `getParameterSignatures`.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
