gianm commented on PR #4527: URL: https://github.com/apache/calcite/pull/4527#issuecomment-3267903512
> Can we have a generic solution that works for all aggregate functions? In this patch I updated all existing `SqlSplittableAggFunction` implementations. If there is something more generic you had in mind, please let me know. > If you have also updated the CountSplitter, I hope you can add a relevant test case. I tried for a bit to find a case where the current `CountSplitter` breaks, but couldn't, so I didn't add a test case. There are already a lot of test cases for `COUNT` splitting. It's possible the current code is "fine" because `COUNT` splits into `COUNT` and `SUM0`, which won't have different nullability. I updated the `CountSplitter` anyway just to keep all the Splitter implementations harmonious. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
