mihaibudiu commented on code in PR #4542:
URL: https://github.com/apache/calcite/pull/4542#discussion_r2353239167


##########
testkit/src/main/java/org/apache/calcite/util/Smalls.java:
##########
@@ -1492,4 +1492,24 @@ public static ByteString eval(String s) {
       }
     }
   }
+
+  /** User-defined function that convert Character[] to VARCHAR. */
+  public static class CharacterArrayFunction {

Review Comment:
   I am not sure I understand this comment; Character[] is a Java type, while 
VARCHAR is a SQL type. 
   
   Is there a test for the BINARY case which is described in the issue title?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to