mihaibudiu commented on code in PR #4424:
URL: https://github.com/apache/calcite/pull/4424#discussion_r2393165387
##########
testkit/src/main/java/org/apache/calcite/test/CalciteAssert.java:
##########
@@ -2355,4 +2362,44 @@ static List<String> unwrap(String java) {
throw new UnsupportedOperationException("snapshot");
}
};
+
+ /** Schema instance for {@link SchemaSpec#UNSIGNED_TYPE}. */
+ private static final Schema UNSIGNED_TYPE_SCHEMA = new AbstractSchema() {
+
+ @Override protected Map<String, Table> getTableMap() {
+ return ImmutableMap.of("test_unsigned", new UnsingedScannableTable());
+ }
+ };
+
+ /** Scannable table for unsigned types test. */
+ private static class UnsingedScannableTable extends AbstractTable implements
ScannableTable {
+
+ /**
+ * {@inheritDoc}
+ *
+ * <p>Table schema is as follows:
+ *
+ * <pre>{@code
+ * test_unsigned(
+ * tiny_id: TINYINT UNSIGNED,
Review Comment:
I think this would be clearer if you start the names with "u": `utiny_id`
(Not sure what `_id` means, maybe `_value` is better)
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeName.java:
##########
@@ -289,6 +289,14 @@ public enum SqlTypeName {
.put(Types.ARRAY, ARRAY)
.build();
+ private static final Map<Integer, SqlTypeName> UNSIGNED_JDBC_TYPE_TO_NAME =
Review Comment:
can you please add a JavaDoc for this map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
