xiedeyantu commented on PR #4573: URL: https://github.com/apache/calcite/pull/4573#issuecomment-3392520812
> I don't see the "advanced" part. Maybe just say "using the existing caching mechanisms"? One way to do this is to have the code maintain some instrumentation and check the numbers with and without caching. Another way is to supply a complex computation which cannot be analyzed without caching (because some internal limits prevent it from being done). Thanks for your suggestion! I have changed the title and added a test for the caching. Please review again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
