xiedeyantu commented on PR #4577: URL: https://github.com/apache/calcite/pull/4577#issuecomment-3399381704
> Yes, I think that once you make them Boolean, you can't change them to something else. Let's see if anyone else has a different suggestion. People may not like a lot of tiny enum classes, but from my experience they are not too bad, and they provide very strong typing. In general, if you can wrap an abstraction, no matter how small, in a class, I think it's worth wrapping (unless performance is a concern). I agree with your suggestion. Since refactoring may not happen immediately, we can first implement the new feature to an ideal state. I will later change it to an enum type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
