xiedeyantu commented on PR #4584: URL: https://github.com/apache/calcite/pull/4584#issuecomment-3416188747
> These SQL files, which present alternate forms of the TPC-DS queries, are not actually being used by the tests: > > * `plus/src/test/resources/sql/tpcds/27a.sql` > * `plus/src/test/resources/sql/tpcds/36a.sql` > * `plus/src/test/resources/sql/tpcds/70a.sql` > * `plus/src/test/resources/sql/tpcds/86a.sql` > > My bad for including them in the reproduce. They could be removed. > > Otherwise it looks good to me. Thank you for dealing with the issue so quickly. Thank you for the review. I've deleted those files and squashed the commits while I was at it. I noticed that @mihaibudiu requested a review from @NobiGo . I'm not entirely sure who will be able to perform the final review and merge this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
