mihaibudiu commented on code in PR #4580:
URL: https://github.com/apache/calcite/pull/4580#discussion_r2440660775


##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -3129,6 +3130,8 @@ protected RelNode createAsofJoin(
     }
     final ImmutableBitSet.Builder requiredColumns = ImmutableBitSet.builder();
     final List<CorrelationId> correlNames = new ArrayList<>();
+    // Mapping from (correlId, originalFieldIndex) to projectedFieldIndex for 
aggregation
+    final Map<Pair<CorrelationId, Integer>, Integer> fieldMapping = new 
HashMap<>();

Review Comment:
   Only if there exists a better data structure for Map<Integer, Integer> which 
you could reuse. Otherwise this is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to