dssysolyatin commented on code in PR #4572:
URL: https://github.com/apache/calcite/pull/4572#discussion_r2420428013
##########
core/src/main/java/org/apache/calcite/rel/rel2sql/RelToSqlConverter.java:
##########
@@ -1141,16 +1138,21 @@ public Result visit(TableModify modify) {
return result(sqlInsert, ImmutableList.of(), modify, null);
}
case UPDATE: {
+ final List<String> updateColumnList =
+ requireNonNull(modify.getUpdateColumnList(),
+ () -> "modify.getUpdateColumnList() is null for " + modify);
final Result input = visitInput(modify, 0);
+ final SqlSelect sourceSelect = input.asSelect();
Review Comment:
I will try to include something.
Also, I found an issue with subqueries like this:
```
UPDATE <table> SET product_id = (SELECT product_id FROM <table> LIMIT 1)
```
I’ll fix it as part of this ticket. It seems someone has already worked on
it 3 years ago https://github.com/apache/calcite/pull/2788. I’ll review it and
see if I can reuse some of those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
