mihaibudiu commented on code in PR #4570:
URL: https://github.com/apache/calcite/pull/4570#discussion_r2412256255
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -2508,6 +2508,15 @@ protected void convertFrom(
convertCollectionTable(bb, call2);
return;
+ case LATERAL:
+ call = (SqlCall) from;
+
+ // Dig out lateral part of join call.
Review Comment:
I think "dig" is a bit too informal. How about "Extract and analyze"?
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -2631,6 +2632,11 @@ private SqlNode registerFrom(
extendList,
forceNullable,
true);
+ // Put the usingScope which is a JoinScope,
+ // in order to see the left items
Review Comment:
I would probably replace "see" with "make visible"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
