zabetak commented on code in PR #4591:
URL: https://github.com/apache/calcite/pull/4591#discussion_r2447568388
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -2040,6 +2040,22 @@ private void checkExponentialCnf(int n) {
checkSimplify(expr, simplified);
}
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7194";>[CALCITE-7194]
+ * Simplify comparisons between function calls and literals to SEARCH</a>. */
+ @Test void testSimplifyComparisonsOfCallsWithLiteralsToSearch() {
Review Comment:
I don't mind adding more test cases if you believe its worth it. However,
using different functions (e.g., UPPER) does not really increase code coverage
and the choice of the function would seem a bit arbitrary (why `UPPER` and not
`LOWER` or another?). Let me know what you prefer.
There are various trade-offs when choosing between unit and end-to-end
tests. For changes in `RexSimplify`, I believe adding "low level" tests in this
class is the best way to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
