mihaibudiu commented on code in PR #4587: URL: https://github.com/apache/calcite/pull/4587#discussion_r2449091934
########## core/src/test/resources/sql/hep.iq: ########## @@ -38,11 +38,11 @@ # 5. Duplicate operations on the same rule: last operation wins # Example: "+Rule1,+Rule1,-Rule1" results in rule being removed # 6. Execution order: -# [HEP Program] (HepPlanner, configurable rules) +# [HEP Program] (HepPlanner, configurable CoreRules.* rules) # ↓ -# [Volcano Program] (VolcanoPlanner, configurable rules) +# [Volcano Program] (VolcanoPlanner, configurable EnumerableRules.* rules) # ↓ -# [Calc Program] (HepPlanner, fixed rules) +# [Calc Program] (HepPlanner, fixed RelOptRules.CALC_RULES) Review Comment: I am talking about what the comment documents. What does `[Calc Program] (HepPlanner, fixed RelOptRules.CALC_RULES)` mean? It seems to me that it says that there is a program executed by the HepPlanner which is initially seeded with the CALC_RULES. If this is correct, you should say it explicitly in English. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
