dssysolyatin commented on code in PR #4572:
URL: https://github.com/apache/calcite/pull/4572#discussion_r2449453489
##########
core/src/main/java/org/apache/calcite/rel/core/TableModify.java:
##########
@@ -55,7 +55,18 @@
* <ul>
* <li>For {@code INSERT}, those rows are the new values;
* <li>for {@code DELETE}, the old values;
- * <li>for {@code UPDATE}, all old values plus updated new values.
+ * <li>for {@code UPDATE}, all old values plus updated new values;
+ * <li>for {@code MERGE}, the rows may contain fields for both {@code INSERT}
and {@code UPDATE}
Review Comment:
I just added the missing documentation. I reviewed how the whole
SqlInsert/SqlDelete/SqlMerge flow works and added the missing docs.
> is this just adding missing documentation, or is it a new feature you are
adding?
If this kind of question comes up in a PR review, I agree. (Though it’s
pretty annoying to make a separate task just to update the docs)
> if it's missing documentation is should probably stay in a separate commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
