iwanttobepowerful commented on code in PR #4614:
URL: https://github.com/apache/calcite/pull/4614#discussion_r2490188965
##########
core/src/test/java/org/apache/calcite/sql2rel/RelDecorrelatorTest.java:
##########
@@ -269,23 +269,17 @@ public static Frameworks.ConfigBuilder config() {
// Verify plan
final String planAfter = ""
+ "LogicalProject(EXPR$0=[1])\n"
- + " LogicalJoin(condition=[AND(IS NOT DISTINCT FROM($0, $2), >($1,
$3))], joinType=[inner])\n"
+ + " LogicalJoin(condition=[AND(=($0, $2), >($1, $3))],
joinType=[inner])\n"
Review Comment:
looks great, same as spark catalyst plan:
```
== Optimized Logical Plan ==
Project [1 AS 1#734]
+- Join Inner, ((total#724 > avg(total)#733) AND (deptno#573 = deptno#756))
:- Filter isnotnull(total#724)
: +- Aggregate [deptno#573], [deptno#573, sum(sal#571) AS total#724]
: +- Project [sal#571, deptno#573]
: +- Filter isnotnull(deptno#573)
: +- Relation
spark_catalog.default.emp[empno#565,ename#566,job#567,age#568,mgr#569,hiredate#570,sal#571,comm#572,deptno#573,email#574,create_datetime#575,upsert_time#576]
parquet
+- Filter isnotnull(avg(total)#733)
+- Aggregate [deptno#756], [avg(total#731) AS avg(total)#733,
deptno#756]
+- Aggregate [deptno#756], [deptno#756, sum(sal#754) AS total#731]
+- Project [sal#754, deptno#756]
+- Filter isnotnull(deptno#756)
+- Relation
spark_catalog.default.emp[empno#748,ename#749,job#750,age#751,mgr#752,hiredate#753,sal#754,comm#755,deptno#756,email#757,create_datetime#758,upsert_time#759]
parquet
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
