xiedeyantu commented on code in PR #4618:
URL: https://github.com/apache/calcite/pull/4618#discussion_r2496891491
##########
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java:
##########
@@ -373,6 +374,9 @@ public JoinReduceExpressionsRule(Class<? extends Join>
joinClass,
@Override public void onMatch(RelOptRuleCall call) {
final Join join = call.rel(0);
+ if (join instanceof LogicalAsofJoin) {
Review Comment:
If we could have a brief explanation here, that would be great.
##########
core/src/main/java/org/apache/calcite/rel/rules/ReduceExpressionsRule.java:
##########
@@ -373,6 +374,9 @@ public JoinReduceExpressionsRule(Class<? extends Join>
joinClass,
@Override public void onMatch(RelOptRuleCall call) {
final Join join = call.rel(0);
+ if (join instanceof LogicalAsofJoin) {
Review Comment:
Or is it possible to support this in the future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
