rubenada commented on code in PR #4614:
URL: https://github.com/apache/calcite/pull/4614#discussion_r2498209509
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -796,17 +796,25 @@ protected RexNode removeCorrelationExpr(
RelNode newRel = relBuilder.build();
+ boolean hasCount = false;
for (AggregateCall aggCall : rel.getAggCallList()) {
if (aggCall.getAggregation() instanceof SqlCountAggFunction) {
- parentPropagatesNullValues = false;
+ hasCount = true;
break;
}
}
if (rel.getGroupType() == Aggregate.Group.SIMPLE
&& rel.getGroupSet().isEmpty()
Review Comment:
Not sure, maybe we need to apply this change... I'd like to know
@suibianwanwank 's opinion on this matter.
In any case, if we decide that this line needs to be fixed, it should be
done on a separate ticket & PR; this is out of the scope of the current PR,
which is merely an optimization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
