dssysolyatin commented on code in PR #4623:
URL: https://github.com/apache/calcite/pull/4623#discussion_r2502332971
##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -3404,6 +3404,23 @@ void checkCorrelatedMapSubQuery(boolean expand) {
sql(sql).ok();
}
+ /**
+ * Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7276";>[CALCITE-7276]
+ * SqlToRelConverter throws exception for UPDATE if identifier expansion
disabled</a>.
+ */
+ @Test void testUpdateWithIdentifierExpansionDisabled() {
Review Comment:
I’ve added a test case with the suffix IdentifierExpansionDisabled (we
already have a few tests with the same suffix). Ideally, we should run all
tests in both configurations: withIdentifierExpansion(true) and
withIdentifierExpansion(false) (SqlValidator.Config.DEFAULT). I’ll create a
separate jira ticket for this so that someone can work on improving it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
