mihaibudiu commented on code in PR #4634:
URL: https://github.com/apache/calcite/pull/4634#discussion_r2530082471
##########
core/src/main/java/org/apache/calcite/tools/RelBuilder.java:
##########
@@ -1930,8 +1930,13 @@ public RelBuilder filter(Iterable<CorrelationId>
variablesSet,
if (config.simplify()) {
conjunctionPredicates = simplifier.simplifyFilterPredicates(predicates);
} else {
+ List<RexNode> simplified = new ArrayList<>();
+ for (RexNode predicate : predicates) {
+ RexNode simple = RexSimplify.simplifyComparisonWithNull(predicate,
getRexBuilder());
Review Comment:
yes, this is a problem with all the PRs for [CALCITE-7070]. Julian suggested
that there should exist no predicates that compare with null, at least when the
pullUpPredicates is invoked, so someone has to take care to remove them on
every code path where they get created. Refer to the JIRA discussion. I
preferred the previous solution, which was shorter, which did allow such
predicates to show up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
