xiedeyantu commented on code in PR #4642:
URL: https://github.com/apache/calcite/pull/4642#discussion_r2539879746
##########
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##########
@@ -2196,17 +2197,10 @@ public RexNode makeLiteral(@Nullable Object value,
RelDataType type,
final MultisetSqlType multisetType = (MultisetSqlType) type;
operands = new ArrayList<>();
for (Object entry : (List) value) {
- final RexNode e = entry instanceof RexLiteral
- ? (RexNode) entry
- : makeLiteral(entry, multisetType.getComponentType(), allowCast);
- operands.add(e);
- }
- if (allowCast) {
- return makeCall(SqlStdOperatorTable.MULTISET_VALUE, operands);
- } else {
- return new RexLiteral((Comparable) FlatLists.of(operands), type,
- sqlTypeName);
+ operands.add(
Review Comment:
I'm not sure I follow. The current thinking is to provide support for the
literal form of MULTISET. But I found that there are still some issues with
pigTest that haven't been resolved. So I'll mark it as a draft for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
