dssysolyatin commented on PR #4641: URL: https://github.com/apache/calcite/pull/4641#issuecomment-3551926305
This test only checks that visit(<RelNodeType> rel) exists, which is a good start. But it doesn’t check whether visit(<RelNodeType> rel) actually works. To test that, each <RelNodeType> object would need to be created manually since they don’t share a common constructor and accept would need to be called on each one to verify that the correct method is invoked -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
