xiedeyantu commented on code in PR #4619: URL: https://github.com/apache/calcite/pull/4619#discussion_r2554806866
########## core/src/main/java/org/apache/calcite/rel/rules/MarkToSemiOrAntiJoinRule.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.rel.rules; + +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.plan.RelOptUtil; +import org.apache.calcite.plan.RelRule; +import org.apache.calcite.plan.Strong; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Filter; +import org.apache.calcite.rel.core.Join; +import org.apache.calcite.rel.core.JoinRelType; +import org.apache.calcite.rel.core.Project; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.tools.RelBuilder; +import org.apache.calcite.util.ImmutableBitSet; + +import org.immutables.value.Value; + +import java.util.ArrayList; +import java.util.List; + +import static org.apache.calcite.plan.RelOptUtil.conjunctions; + +/** + * Rule to simplify a mark join to semi join or anti join. Review Comment: Can there be a brief comment in the Javadoc? ########## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ########## @@ -11413,4 +11413,250 @@ private void checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) { }) .check(); } + + @Test void testTopDownGeneralDecorrelateForFilterExists() { Review Comment: Add a JIRA link. If you don't want to add one for every case, at least add one. ########## core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java: ########## @@ -11413,4 +11413,250 @@ private void checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) { }) .check(); } + + @Test void testTopDownGeneralDecorrelateForFilterExists() { + final String sql = "select empno from emp where " + + "exists(select * from dept where dept.deptno = emp.deptno)"; + + sql(sql) + .withRule( + CoreRules.FILTER_SUBQUERY_REMOVE_ENABLE_MARK_JOIN, + CoreRules.PROJECT_MERGE, + CoreRules.PROJECT_REMOVE) + .withLateDecorrelate(true) + .withTopDownGeneralDecorrelate(true) + .check(); + } + + @Test void testTopDownGeneralDecorrelateForFilterSome() { + final String sql = "select empno from emp where " + + "empno > SOME(select empno from emp_b where emp.ename = emp_b.ename)"; + + sql(sql) + .withRule( + CoreRules.FILTER_SUBQUERY_REMOVE_ENABLE_MARK_JOIN, + CoreRules.PROJECT_MERGE, + CoreRules.PROJECT_REMOVE) + .withLateDecorrelate(true) + .withTopDownGeneralDecorrelate(true) + .check(); + } + + @Test void testTopDownGeneralDecorrelateForFilterNotIn() { + final String sql = "select empno from emp where " + + "empno not in (select empno from emp_b where emp.ename = emp_b.ename)"; + + sql(sql) + .withRule( + CoreRules.FILTER_SUBQUERY_REMOVE_ENABLE_MARK_JOIN, Review Comment: Indent with 4 spaces. ########## core/src/main/java/org/apache/calcite/rel/rules/CoreRules.java: ########## @@ -945,4 +945,18 @@ private CoreRules() {} * into equivalent {@link Union} ALL of GROUP BY operations. */ public static final AggregateGroupingSetsToUnionRule AGGREGATE_GROUPING_SETS_TO_UNION = AggregateGroupingSetsToUnionRule.Config.DEFAULT.toRule(); + + /** Rule that converts sub-queries from filter expressions into + * {@link Correlate} instances. It will rewrite SOME/EXISTS/IN to a MARK type Correlate. */ + public static final SubQueryRemoveRule FILTER_SUBQUERY_REMOVE_ENABLE_MARK_JOIN = + SubQueryRemoveRule.Config.FILTER_ENABLE_MARK_JOIN.toRule(); Review Comment: It would be better to keep the rules related to SubQueryRemove together, and their names could be unified as well. Would "FILTER_SUB_QUERY_REMOVE_MARK_JOIN" be better? "ENABLE" seems a bit odd. ########## core/src/main/java/org/apache/calcite/sql2rel/TopDownGeneralDecorrelator.java: ########## @@ -0,0 +1,1009 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql2rel; + +import org.apache.calcite.plan.RelOptUtil; +import org.apache.calcite.plan.Strong; +import org.apache.calcite.plan.hep.HepPlanner; +import org.apache.calcite.plan.hep.HepProgram; +import org.apache.calcite.rel.RelCollation; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Aggregate; +import org.apache.calcite.rel.core.AggregateCall; +import org.apache.calcite.rel.core.Correlate; +import org.apache.calcite.rel.core.CorrelationId; +import org.apache.calcite.rel.core.Filter; +import org.apache.calcite.rel.core.Join; +import org.apache.calcite.rel.core.JoinRelType; +import org.apache.calcite.rel.core.Project; +import org.apache.calcite.rel.core.SetOp; +import org.apache.calcite.rel.core.Sort; +import org.apache.calcite.rel.rules.CoreRules; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rex.RexCall; +import org.apache.calcite.rex.RexCorrelVariable; +import org.apache.calcite.rex.RexFieldAccess; +import org.apache.calcite.rex.RexInputRef; +import org.apache.calcite.rex.RexNode; +import org.apache.calcite.rex.RexShuttle; +import org.apache.calcite.rex.RexUtil; +import org.apache.calcite.rex.RexWindow; +import org.apache.calcite.sql.SqlAggFunction; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.fun.SqlCountAggFunction; +import org.apache.calcite.sql.fun.SqlStdOperatorTable; +import org.apache.calcite.sql2rel.RelDecorrelator.CorDef; +import org.apache.calcite.sql2rel.RelDecorrelator.Frame; +import org.apache.calcite.tools.RelBuilder; +import org.apache.calcite.util.ImmutableBitSet; +import org.apache.calcite.util.Litmus; +import org.apache.calcite.util.Pair; +import org.apache.calcite.util.ReflectUtil; +import org.apache.calcite.util.ReflectiveVisitor; +import org.apache.calcite.util.mapping.Mappings; + +import com.google.common.collect.ImmutableList; +import com.google.common.collect.ImmutableSet; + +import org.checkerframework.checker.nullness.qual.Nullable; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.NavigableMap; +import java.util.NavigableSet; +import java.util.Set; +import java.util.TreeMap; +import java.util.TreeSet; +import java.util.stream.IntStream; + +import static java.util.Objects.requireNonNull; + +/** + * A top‑down, generic decorrelation algorithm that can handle deep nestings of correlated + * subqueries and that generalizes to complex query constructs. More details are in paper: + * <a href="https://dl.gi.de/items/b9df4765-d1b0-4267-a77c-4ce4ab0ee62d";> + * Improving Unnesting of Complex Queries</a> + */ +public class TopDownGeneralDecorrelator implements ReflectiveVisitor { Review Comment: Please add an experimental annotation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
