silundong commented on code in PR #4653:
URL: https://github.com/apache/calcite/pull/4653#discussion_r2580514493
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -3347,7 +3358,10 @@ private static class BinaryImplementor extends
AbstractRexCallImplementor {
}
// For checked arithmetic call the method.
- if (CHECKED_OPERATORS.contains(op)) {
+ if (CHECKED_OPERATORS.contains(op)
+ || op.kind == SqlKind.DIVIDE_0_NULL
+ || op.kind == SqlKind.MOD_0_NULL
+ || op.kind == SqlKind.CHECKED_DIVIDE_0_NULL) {
Review Comment:
This seems to target checked arithmetic. Are DIVIDE_0_NULL and MOD_0_NULL
part of that? Can we add them to CHECKED_OPERATORS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
