xiedeyantu commented on code in PR #4662:
URL: https://github.com/apache/calcite/pull/4662#discussion_r2591128282
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -778,6 +805,87 @@ private static int calculatePermuteOffset(List<SqlNode>
selectItems) {
return 0;
}
+ private static boolean matchesExcludeNames(List<String> columnNames,
+ List<String> excludeNames, SqlNameMatcher nameMatcher) {
+ if (excludeNames.size() > columnNames.size()) {
Review Comment:
Sorry, this should be a comparison between column names and fully qualified
names. For example, [deptno] (in excludeNames) and [emp.deptno] (in
columnNames).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
