xiedeyantu commented on PR #4667: URL: https://github.com/apache/calcite/pull/4667#issuecomment-3616192507
I'm not very familiar with the changes you made, but could you add a test case to verify your modifications? Removing test cases doesn't seem like a good choice. We can wait for someone else who is familiar with this legacy code to determine if the changes are correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
