dssysolyatin commented on code in PR #4662: URL: https://github.com/apache/calcite/pull/4662#discussion_r2594791289
########## core/src/main/java/org/apache/calcite/sql/SqlStarExclude.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.util.ImmutableNullableList; + +import org.checkerframework.checker.nullness.qual.Nullable; + +import java.util.List; + +import static java.util.Objects.requireNonNull; + +/** + * Represents {@code SELECT * EXCLUDE(...)}. + */ +public class SqlStarExclude extends SqlCall { + public static final SqlOperator OPERATOR = + new SqlSpecialOperator("SELECT_STAR_EXCLUDE", SqlKind.OTHER) { + @Override public SqlCall createCall( + @Nullable SqlLiteral functionQualifier, + SqlParserPos pos, + SqlNode... operands) { + return new SqlStarExclude( + (SqlIdentifier) requireNonNull(operands[0], "starIdentifier"), + (SqlNodeList) requireNonNull(operands[1], "excludeList")); + } + }; + + private final SqlIdentifier starIdentifier; + private final SqlNodeList excludeList; + + public SqlStarExclude(SqlIdentifier starIdentifier, SqlNodeList excludeList) { + super(requireNonNull(starIdentifier, "starIdentifier").getParserPosition()); + this.starIdentifier = starIdentifier; + this.excludeList = requireNonNull(excludeList, "excludeList"); + } + + public SqlIdentifier getStarIdentifier() { + return starIdentifier; + } + + public SqlNodeList getExcludeList() { + return excludeList; + } + + @Override public SqlOperator getOperator() { + return OPERATOR; + } + + @Override public SqlKind getKind() { + return OPERATOR.getKind(); + } + + @Override public List<SqlNode> getOperandList() { + return ImmutableNullableList.of(starIdentifier, excludeList); Review Comment: Why it is `ImmutableNullableList` and not just ImmutableList ? If I understand correctly both `starIdentifier` and `excludeList` are not nullable. ########## core/src/main/java/org/apache/calcite/sql/SqlStarExclude.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to you under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.calcite.sql; + +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.util.ImmutableNullableList; + +import org.checkerframework.checker.nullness.qual.Nullable; + +import java.util.List; + +import static java.util.Objects.requireNonNull; + +/** + * Represents {@code SELECT * EXCLUDE(...)}. + */ +public class SqlStarExclude extends SqlCall { + public static final SqlOperator OPERATOR = + new SqlSpecialOperator("SELECT_STAR_EXCLUDE", SqlKind.OTHER) { + @Override public SqlCall createCall( + @Nullable SqlLiteral functionQualifier, + SqlParserPos pos, + SqlNode... operands) { + return new SqlStarExclude( + (SqlIdentifier) requireNonNull(operands[0], "starIdentifier"), + (SqlNodeList) requireNonNull(operands[1], "excludeList")); + } + }; + + private final SqlIdentifier starIdentifier; + private final SqlNodeList excludeList; + + public SqlStarExclude(SqlIdentifier starIdentifier, SqlNodeList excludeList) { + super(requireNonNull(starIdentifier, "starIdentifier").getParserPosition()); + this.starIdentifier = starIdentifier; + this.excludeList = requireNonNull(excludeList, "excludeList"); + } + + public SqlIdentifier getStarIdentifier() { + return starIdentifier; + } + + public SqlNodeList getExcludeList() { + return excludeList; + } + + @Override public SqlOperator getOperator() { + return OPERATOR; + } + + @Override public SqlKind getKind() { + return OPERATOR.getKind(); + } + + @Override public List<SqlNode> getOperandList() { + return ImmutableNullableList.of(starIdentifier, excludeList); + } + + @Override public SqlNode clone(SqlParserPos pos) { + return new SqlStarExclude((SqlIdentifier) starIdentifier.clone(pos), + excludeList.clone(pos)); + } + + @Override public void unparse(SqlWriter writer, int leftPrec, int rightPrec) { + starIdentifier.unparse(writer, leftPrec, rightPrec); + writer.sep("EXCLUDE"); + writer.print("("); + for (int i = 0; i < excludeList.size(); i++) { Review Comment: Why do you need your own unparse logic for SqlNodeList instead of using `excludeList.unparse` ``` final SqlWriter.Frame frame = writer.startList("(", ")"); excludeList.unparse(...) writer.endList(frame) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
