xiedeyantu commented on PR #4671: URL: https://github.com/apache/calcite/pull/4671#issuecomment-3634700145
> The question is whether the information they need to inject exists at parsing time or only at validation time. Also, I suspect you want to reject a SELECT that has both BY and ORDER BY or GROUP BY. It's possible to retain this information during the parsing phase for easier processing during verification. I'm unsure if not retaining this information during parsing is easier to handle, as I'm not very familiar with this part of the code. If you think an additional SqlBy implementation is needed, I'll consider it. Regarding your point about rejecting GROUP BY and ORDER BY, I hadn't considered that. So, could you give me a general suggestion for modification? I'm also currently learning this module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
