asolimando commented on code in PR #4672:
URL: https://github.com/apache/calcite/pull/4672#discussion_r2606971647
##########
plus/src/main/java/org/apache/calcite/adapter/os/FilesTableFunction.java:
##########
@@ -144,6 +145,49 @@ private Enumerable<String> sourceMacOs() {
return Processes.processLines('\n', args);
}
+ private Enumerable<String> sourceGnuStat() {
Review Comment:
I agree with the design principle, but as @xiedeyantu noted, this is an
implementation detail specific to this table function and unlikely to be reused
elsewhere, so I'd be inclined to leave it as-is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
