xiedeyantu commented on code in PR #4679:
URL: https://github.com/apache/calcite/pull/4679#discussion_r2610767007
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexToLixTranslator.java:
##########
@@ -430,6 +430,9 @@ private Expression getConvertExpression(
return Expressions.call(BuiltInMethod.STRING_TO_BOOLEAN.method,
operand);
default:
+ if (sourceType.getFamily() == SqlTypeFamily.NUMERIC) {
Review Comment:
Would it be better to keep the same case syntax as above?
##########
core/src/test/java/org/apache/calcite/rex/RexProgramTest.java:
##########
@@ -3152,7 +3152,9 @@ private SqlOperator getNoDeterministicOperator() {
checkSimplify(cast(literal(1), varcharType), "'1':VARCHAR(10)");
checkSimplifyUnchanged(cast(literalAbc, booleanType));
checkSimplify(cast(literal(1), booleanType),
- "false"); // different from Hive
+ "true"); // different from Hive
Review Comment:
Is this comment still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
