mihaibudiu commented on PR #4619: URL: https://github.com/apache/calcite/pull/4619#issuecomment-3643134137
One way to migrate tests is to actually subclass the class which runs the tests and run the same tests using a different configuration/fixture. For xml based tests (RelOptRulesTest) this may work well, since a new XML file will be associated with the new class. A big problem with quidem will be that many tests include plans, many of which will change with the new decorrelator. I personally think that including plans in quidem tests should be avoided, exactly for this reason: plans are sensitive to the optimizations applied, whereas the quidem tests are designed to check end-to-end correctness. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
