mihaibudiu commented on code in PR #4678:
URL: https://github.com/apache/calcite/pull/4678#discussion_r2612934425
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/PhysType.java:
##########
@@ -134,6 +134,13 @@ Expression fieldReference(Expression expression, int field,
*/
Expression generateAccessorWithoutNulls(List<Integer> fields);
+ /**
+ * Similar to {@link #generateAccessor(List)} and {@link
#generateAccessorWithoutNulls(List)},
+ * but it's null-aware. If one of the fields is <code>null</code> and this
field is marked as
+ * TRUE in filterNulls, it will return <code>null</code>.
Review Comment:
I think this is a much better explanation for the JavaDoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
