julianhyde commented on code in PR #4671:
URL: https://github.com/apache/calcite/pull/4671#discussion_r2615667634
##########
core/src/main/java/org/apache/calcite/sql/SqlUtil.java:
##########
@@ -1294,6 +1294,46 @@ public static boolean containsCall(SqlNode node,
}
}
+ /**
+ * Strips sort modifiers (DESC, NULLS FIRST/LAST) from a node.
Review Comment:
Historically we haven't used 'with' or 'without' prefixes for static methods.
I think the name is fine, but the comment should be more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
