xiedeyantu commented on code in PR #4692:
URL: https://github.com/apache/calcite/pull/4692#discussion_r2629135193
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -11491,4 +11463,196 @@ public Sql schema(CalciteAssert.SchemaSpec
schemaSpec) {
relFn, transforms);
}
}
+
+ /** Test case for
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7279";>[CALCITE-7279]
+ * ClickHouse dialect should wrap nested JOINs</a>.
+ *
+ * <p>ClickHouse does not support nested JOIN syntax directly.
+ * When a JOIN's right side is another JOIN, it must be wrapped
+ * in a SELECT * FROM (...) subquery. */
+ @Test void testClickHouseNestedJoin() {
+ final String query = "SELECT e.empno, j.dname, j.loc\n"
+ + "FROM emp e\n"
+ + "LEFT JOIN (\n"
+ + " SELECT d1.deptno, d1.dname, d2.loc\n"
+ + " FROM dept d1\n"
+ + " INNER JOIN dept d2 ON d1.deptno = d2.deptno\n"
+ + ") AS j ON e.deptno = j.deptno";
+
+ final String sql = sql(query)
+ .schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
+ .withClickHouse()
+ .exec();
+
+ assertThat(sql, containsString("LEFT JOIN (SELECT *"));
Review Comment:
I think use following is fine. Just using a expected string.
```
sql(query)
.schema(CalciteAssert.SchemaSpec.JDBC_SCOTT)
.withClickHouse()
.ok(expected);
```
##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -1825,4 +1825,7 @@ private ContextImpl(DatabaseProduct databaseProduct,
conformance, nullCollation, dataTypeSystem, jethroInfo);
}
}
+ public boolean mustWrapNestedJoin(RelNode relNode) {
Review Comment:
Would it be better to use the name `supportWrapNestedJoin`? This method
needs to be moved closer to other similar methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
