NobiGo commented on code in PR #4691:
URL: https://github.com/apache/calcite/pull/4691#discussion_r2633416767
##########
core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java:
##########
@@ -673,7 +673,7 @@ public TrimResult trimFields(
// Build new filter with trimmed input and condition.
relBuilder.push(newInput)
- .filter(filter.getVariablesSet(), newConditionExpr);
+ .filter(correlationIds, newConditionExpr);
Review Comment:
Yes, I agree with your view. In principle, the RelNode constructed via
RelNodeBuilder can be directly converted into SQL. However, I've found that
some of the generated RelNodes cannot be converted. Regarding what you
mentioned about the missing variablesSet—its maybe should merge these two—and
the SQL test cases are also somewhat incomplete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
