xiedeyantu commented on code in PR #4697: URL: https://github.com/apache/calcite/pull/4697#discussion_r2633946156
########## site/_docs/algebra.md: ########## @@ -239,39 +238,39 @@ When you are building a relational expression that accepts multiple inputs, you need to build field references that take that into account. This occurs most often when building join conditions. -Suppose you are building a join on EMP, -which has 8 fields [EMPNO, ENAME, JOB, MGR, HIREDATE, SAL, COMM, DEPTNO] -and DEPT, -which has 3 fields [DEPTNO, DNAME, LOC]. +Suppose you are building a join on `EMP`, +which has 8 fields [`EMPNO`, `ENAME`, `JOB`, `MGR`, `HIREDATE`, `SAL`, `COMM`, `DEPTNO`] +and `DEPT`, +which has 3 fields [`DEPTNO`, `DNAME`, `LOC`]. Internally, Calcite represents those fields as offsets into a combined input row with 11 fields: the first field of the left input is -field #0 (0-based, remember), and the first field of the right input is -field #8. +field `#0 (0-based, remember)·, and the first field of the right input is Review Comment: `·` should change to` `` ########## site/_docs/algebra.md: ########## @@ -239,39 +238,39 @@ When you are building a relational expression that accepts multiple inputs, you need to build field references that take that into account. This occurs most often when building join conditions. -Suppose you are building a join on EMP, -which has 8 fields [EMPNO, ENAME, JOB, MGR, HIREDATE, SAL, COMM, DEPTNO] -and DEPT, -which has 3 fields [DEPTNO, DNAME, LOC]. +Suppose you are building a join on `EMP`, +which has 8 fields [`EMPNO`, `ENAME`, `JOB`, `MGR`, `HIREDATE`, `SAL`, `COMM`, `DEPTNO`] +and `DEPT`, +which has 3 fields [`DEPTNO`, `DNAME`, `LOC`]. Internally, Calcite represents those fields as offsets into a combined input row with 11 fields: the first field of the left input is -field #0 (0-based, remember), and the first field of the right input is -field #8. +field `#0 (0-based, remember)·, and the first field of the right input is Review Comment: `·` should change to` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
