dssysolyatin commented on code in PR #4696:
URL: https://github.com/apache/calcite/pull/4696#discussion_r2642219431
##########
server/src/test/java/org/apache/calcite/test/ServerParserTest.java:
##########
@@ -86,6 +99,24 @@ class ServerParserTest extends SqlParserTest {
sql(sql).ok(expected);
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7339";>[CALCITE-7339]
+ * Most classes in SqlDdlNodes use an incorrect SqlCallFactory</a>. */
+ @Test void testShuttle() throws SqlParseException {
Review Comment:
Does this test tests everything ?
Can we just add common test
[SqlParserTest.java](https://github.com/apache/calcite/pull/4644/files#diff-766dbf236baaf33399a8d3620404b261faa80c27dadb95379e0747f915380e44)
but have boolean flag which enable it only for `ServerUnParserTest` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
