mihaibudiu commented on code in PR #4707:
URL: https://github.com/apache/calcite/pull/4707#discussion_r2649272648


##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdUtil.java:
##########
@@ -464,6 +464,32 @@ public static double capInfinity(Double d) {
     return d.isInfinite() ? Double.MAX_VALUE : d;
   }
 
+  /**
+   * Returns the numeric value stored in a literal as a double.
+   *
+   * <p>Throws when the literal exceeds {@link Double#MAX_VALUE} instead of
+   * silently rounding to infinity. Doubles still approximate large integers 
(53
+   * bits of mantissa), so the returned value becomes only an approximation 
when
+   * occupancy reaches that limit.

Review Comment:
   when numbers are very large



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to