dssysolyatin commented on code in PR #4644:
URL: https://github.com/apache/calcite/pull/4644#discussion_r2649905305
##########
babel/src/test/java/org/apache/calcite/test/BabelParserTest.java:
##########
@@ -390,7 +391,12 @@ private void checkParseInfixCast(String sqlType) {
}
@Test void testPostgresSqlSetOption() {
- SqlParserFixture f = fixture().withDialect(PostgresqlSqlDialect.DEFAULT);
+ // UnparsingTesterImpl has a check where it unparses a SqlNode into a SQL
string
+ // using the calcite dialect, and then parses it back into a SqlNode.
+ // But the SQL string produced by the calcite dialect for `SET` cannot
always be parsed back.
Review Comment:
I don’t see a reason to spend time on it, as this is a very specific case.
Additionally, I think almost nobody uses this syntax. I originally
introduced it while working on the implementation of the Postgres wire protocol
and integrating various tools on top of it. At that time, I didn’t observe much
interest in this feature outside the company I was working for
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
