xiedeyantu commented on code in PR #4598:
URL: https://github.com/apache/calcite/pull/4598#discussion_r2660057186
##########
core/src/main/java/org/apache/calcite/rel/rules/AggregateExtractLiteralAggRule.java:
##########
@@ -34,7 +34,10 @@
import java.util.Map;
/**
- * AggregateExtractLiteralAggRule gets rid of the LITERAL_AGG into most
databases can handle.
+ * Rule transforms an {@link org.apache.calcite.rel.core.Aggregate} containing
Review Comment:
An example of SQL or plan is required here. Please refer to other rules.
##########
core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java:
##########
@@ -11413,4 +11413,88 @@ private void
checkLoptOptimizeJoinRule(LoptOptimizeJoinRule rule) {
})
.check();
}
+
+ /** Test case of
+ * <a
href="https://issues.apache.org/jira/browse/CALCITE-7242";>[CALCITE-7242]
+ * Implement a rule to eliminate LITERAL_AGG so that other databases can
handle it</a>. */
+ @Test void testAggregateExtractLiteralAggRule1() {
Review Comment:
This doesn't seem to have been modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
