mihaibudiu commented on code in PR #4730:
URL: https://github.com/apache/calcite/pull/4730#discussion_r2673262519
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -2125,6 +2125,37 @@ public static boolean eq(Object b0, Object b1) {
return b0.equals(b1);
}
+ /**
+ * Performs deep equality comparison for arrays or lists.
+ */
+ public static boolean deepEquals(@Nullable Object o0, @Nullable Object o1) {
Review Comment:
I remember seeing recently comparisons being supported for deep objects. I
hope this implementation is "compatible" with that (in general, equals has to
provide the same result as comparison for equal objects).
Moreover, this does not handle MAP objects. Perhaps it handles MULTISET
objects. Will it work for ROW objects?
I think that a big problem we have is that the exact representation of all
these objects in Enumerable land is not clearly specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
