mihaibudiu commented on code in PR #4735:
URL: https://github.com/apache/calcite/pull/4735#discussion_r2677891262
##########
core/src/main/java/org/apache/calcite/sql/type/SqlTypeCoercionRule.java:
##########
@@ -167,22 +167,24 @@ private SqlTypeCoercionRule(Map<SqlTypeName,
ImmutableSet<SqlTypeName>> map) {
.build());
}
- // BINARY is castable from VARBINARY, CHARACTERS.
+ // BINARY is castable from VARBINARY, CHARACTERS, INTEGERS
coerceRules.add(SqlTypeName.BINARY,
coerceRules.copyValues(SqlTypeName.BINARY)
.add(SqlTypeName.VARBINARY)
.addAll(SqlTypeName.CHAR_TYPES)
.add(SqlTypeName.UUID)
.addAll(SqlTypeName.INT_TYPES)
+ .addAll(SqlTypeName.UNSIGNED_TYPES)
Review Comment:
This change is actually unrelated to this issue, but I think it's an
omission.
I could file a separate issue too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
