dssysolyatin commented on code in PR #4746:
URL: https://github.com/apache/calcite/pull/4746#discussion_r2692250151
##########
core/src/main/java/org/apache/calcite/sql/SqlWindowTableFunction.java:
##########
@@ -233,6 +233,12 @@ boolean checkIntervalOperands(SqlCallBinding callBinding,
int startPos) {
void validateColumnNames(SqlValidator validator,
List<String> fieldNames, List<SqlNode> columnNames) {
final SqlNameMatcher matcher =
validator.getCatalogReader().nameMatcher();
+ for (SqlNode name : columnNames) {
+ if (! (name instanceof SqlIdentifier)) {
Review Comment:
Nit: I think there's an extra space here after `!`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
