xiedeyantu commented on code in PR #4758:
URL: https://github.com/apache/calcite/pull/4758#discussion_r2710950318
##########
core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml:
##########
@@ -9158,6 +9158,22 @@ LogicalProject(EMPNO=[$0], ENAME=[$1], T=[$10])
LogicalProject(EMPNO=[$0], ENAME=[$1], T=[$10])
LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], SLACKER=[$8], $f9=[CASE(=($0, 7934), 7934,
null:INTEGER)], $f10=[CASE(=($0, 7934), CURRENT_TIMESTAMP, null:TIMESTAMP(0))])
LogicalTableScan(table=[[CATALOG, SALES, EMP]])
+]]>
+ </Resource>
+ </TestCase>
+ <TestCase name="testLeftMarkJoinWithSingleValues">
+ <Resource name="planBefore">
+ <![CDATA[
+LogicalJoin(condition=[=($0, $8)], joinType=[left_mark])
+ LogicalTableScan(table=[[scott, EMP]])
+ LogicalValues(tuples=[[{ 1 }]])
+]]>
+ </Resource>
+ <Resource name="planAfter">
+ <![CDATA[
+LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3], HIREDATE=[$4],
SAL=[$5], COMM=[$6], DEPTNO=[$7], $f8=[=($0, 1)])
+ LogicalFilter(condition=[=($0, 1)])
Review Comment:
I apologize, I realized this plan was incorrect. The filter shouldn't be
kept here, as it would filter out the data. The `marker ` should be kept
directly in the project. My final commit fixed this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
