mihaibudiu commented on code in PR #4767:
URL: https://github.com/apache/calcite/pull/4767#discussion_r2722629704
##########
core/src/test/java/org/apache/calcite/sql2rel/RelDecorrelatorTest.java:
##########
@@ -356,6 +356,138 @@ public static Frameworks.ConfigBuilder config() {
assertThat(after, hasTree(planAfter));
}
+ /** Test case for <a
href="https://issues.apache.org/jira/browse/CALCITE-7394";>[CALCITE-7394]
+ * Nested sub-query with multiple levels of correlation returns incorrect
results</a>. */
+ @Test void test7394() {
+ final FrameworkConfig frameworkConfig = config().build();
+ final RelBuilder builder = RelBuilder.create(frameworkConfig);
+ final RelOptCluster cluster = builder.getCluster();
+ final Planner planner = Frameworks.getPlanner(frameworkConfig);
+ final String sql = ""
+ + "select d.dname,\n"
+ + " (select count(*)\n"
+ + " from emp e\n"
+ + " where e.deptno = d.deptno\n"
+ + " and exists (\n"
+ + " select 1\n"
+ + " from (values (1000), (2000), (3000)) as v(sal)\n"
+ + " where e.sal > v.sal\n"
+ + " and d.deptno * 100 < v.sal\n"
+ + " )\n"
+ + " ) as c\n"
+ + "from dept d\n"
+ + "order by d.dname";
+ final RelNode originalRel;
+ try {
+ final SqlNode parse = planner.parse(sql);
+ final SqlNode validate = planner.validate(parse);
+ originalRel = planner.rel(validate).rel;
+ } catch (Exception e) {
+ throw TestUtil.rethrow(e);
+ }
+
+ final HepProgram hepProgram = HepProgram.builder()
+ .addRuleCollection(
+ ImmutableList.of(
+ // SubQuery program rules
+ CoreRules.FILTER_SUB_QUERY_TO_CORRELATE,
+ CoreRules.PROJECT_SUB_QUERY_TO_CORRELATE,
+ CoreRules.JOIN_SUB_QUERY_TO_CORRELATE))
+ .build();
+ final Program program =
+ Programs.of(hepProgram, true,
+ requireNonNull(cluster.getMetadataProvider()));
+ final RelNode before =
+ program.run(cluster.getPlanner(), originalRel, cluster.traitSet(),
+ Collections.emptyList(), Collections.emptyList());
+ final String planBefore = ""
+ + "LogicalSort(sort0=[$0], dir0=[ASC])\n"
+ + " LogicalProject(DNAME=[$1], C=[$3])\n"
+ + " LogicalCorrelate(correlation=[$cor0], joinType=[left],
requiredColumns=[{0}])\n"
+ + " LogicalTableScan(table=[[scott, DEPT]])\n"
+ + " LogicalAggregate(group=[{}], EXPR$0=[COUNT()])\n"
+ + " LogicalProject(EMPNO=[$0], ENAME=[$1], JOB=[$2], MGR=[$3],
HIREDATE=[$4], SAL=[$5], COMM=[$6], DEPTNO=[$7])\n"
+ + " LogicalFilter(condition=[=($7, $cor0.DEPTNO)])\n"
+ + " LogicalCorrelate(correlation=[$cor1], joinType=[inner],
requiredColumns=[{5}])\n"
+ + " LogicalTableScan(table=[[scott, EMP]])\n"
+ + " LogicalAggregate(group=[{0}])\n"
+ + " LogicalProject(i=[true])\n"
+ + "
LogicalFilter(condition=[AND(>(CAST($cor1.SAL):DECIMAL(12, 2),
CAST($0):DECIMAL(12, 2) NOT NULL), <(*($cor0.DEPTNO, 100), $0))])\n"
+ + " LogicalValues(tuples=[[{ 1000 }, { 2000 }, {
3000 }]])\n";
+ assertThat(before, hasTree(planBefore));
+
+ // Decorrelate without any rules, just "purely" decorrelation algorithm on
RelDecorrelator
+ final RelNode after =
+ RelDecorrelator.decorrelateQuery(before, builder,
RuleSets.ofList(Collections.emptyList()),
+ RuleSets.ofList(Collections.emptyList()));
+ // before fix:
Review Comment:
reading these plans is not easy, maybe you could also show a DIFF sign on
the lines which are changed
##########
core/src/test/resources/sql/sub-query.iq:
##########
@@ -5617,6 +5617,181 @@ ORDER BY deptno;
!ok
+# [CALCITE-7394] Nested sub-query with multiple levels of correlation returns
incorrect results
Review Comment:
I assume these queries have been validated using an external database,
If you say this in a comment it makes it somewhat easier for future people
who will look at this code to trust the results.
We have had tests with incorrect results checked in before, so it's
important to mark validated results as such.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
