silundong commented on code in PR #4769:
URL: https://github.com/apache/calcite/pull/4769#discussion_r2725547138
##########
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##########
@@ -566,6 +568,17 @@ public interface JoinRightEmptyRuleConfig extends
PruneEmptyRule.Config {
call.transformTo(join.getLeft());
return;
}
+ if (join.getJoinType() == JoinRelType.LEFT_MARK) {
Review Comment:
```
/**
* Rule that converts a {@link org.apache.calcite.rel.core.Join}
* to empty if its right child is empty.
*
* <p>Examples:
*
* <ul>
* <li>Join(Scan(Emp), Empty, INNER) becomes Empty
* <li>Join(Scan(Emp), Empty, RIGHT) becomes Empty
* <li>Join(Scan(Emp), Empty, SEMI) becomes Empty
* <li>Join(Scan(Emp), Empty, ANTI) becomes Scan(Emp)
* </ul>
*/
public static final RelOptRule JOIN_RIGHT_INSTANCE =
JoinRightEmptyRuleConfig.DEFAULT.toRule();
```
Can you please add a comment for left mark join?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
